New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to check for constant 1 in _indexsearch? #19

Open

msmdev opened this issue Nov 19, 2020 · 1 comment

Owner

msmdev commented Nov 19, 2020

Mb. we need to check here, if the first vector is constantly 1 and not only constant?

msmtools/msmtools/analysis/dense/gpcca.py

Line 418 in d662da6

if not (diffs[0] < 1e-6):

msmdev mentioned this issue

Gpcca tests #18

Closed

3 tasks

michalk8 commented Dec 1, 2020

Will be dealt with in #18
Implemented in: https://github.com/michalk8/msmtools/blob/gpcca_tests/msmtools/analysis/dense/gpcca.py#L416
Tested in: https://github.com/michalk8/msmtools/blob/gpcca_tests/tests/analysis/impl/dense/gpcca_test.py#L270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment