-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subworkflow: genome nexus - vcf2maf + annotationpipeline #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rashmi, a suggested change and a few questions. Overall, things look pretty good!
…-omics-workflows/modules into feature/genome_nexus_final avoiding merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnaidu a new general note is that we'd like to switch to using this version of vcf2maf
: https://github.com/genome-nexus/vcf2maf-lite. Let me know if I can help.
…branch. subworkflow will be built off of here
- "genomenexus": | ||
description: "DSL2 module to perform an annotation of MAF file type using the genomenexus suite of conversion and annotation tools." | ||
homepage: "https://github.com/genome-nexus/genome-nexus-annotation-pipeline/" | ||
documentation: "https://github.com/genome-nexus/.github/blob/main/profile/README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would update the description. The tool itself (genomenexus) is not a nextflow dsl2 module its just a java pipeline.
Also: you can maybe use this for the docs (https://docs.genomenexus.org/)
7001ebc
to
dc38308
Compare
a72c6c7
to
dc38308
Compare
|
||
cat <<-END_VERSIONS > versions.yml | ||
"${task.process}": | ||
genomenexus: 'annotation pipeline version 1.0.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnaidu i know this is merged by we would need to update these versions
|
||
cat <<-END_VERSIONS > versions.yml | ||
"${task.process}": | ||
genomenexus: 'annotation pipeline version 1.0.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnaidu here as well
label 'process_low' | ||
|
||
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
'ghcr.io/msk-access/genomenexus:vcf2maf_lite': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnaidu Also for both containers, is genome nexus team not hosting them?
Genome Nexus VCF2MAF module + tests (tested locally and with nf-core data)
to be used in SNPs/indels nextflow workflow
PR checklist
versions.yml
file.label