Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subworkflow: genome nexus - vcf2maf + annotationpipeline #58

Merged
merged 69 commits into from
Jul 11, 2024

Conversation

rnaidu
Copy link
Collaborator

@rnaidu rnaidu commented Mar 18, 2024

Genome Nexus VCF2MAF module + tests (tested locally and with nf-core data)

to be used in SNPs/indels nextflow workflow

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure code lints (using prettier)
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • nf-test test --profile=docker --tag
    • nf-test test --profile=singularity --tag
    • nf-test test --profile=conda --tag (not applicable; conda nf-test is disabled)

@rnaidu rnaidu requested a review from a team as a code owner March 18, 2024 18:34
@rnaidu rnaidu marked this pull request as draft March 18, 2024 18:39
@rnaidu rnaidu removed the request for review from a team March 18, 2024 18:40
@rnaidu rnaidu self-assigned this Mar 18, 2024
@rnaidu rnaidu requested a review from a team March 18, 2024 20:21
@rnaidu rnaidu marked this pull request as ready for review March 18, 2024 20:21
@rnaidu rnaidu requested a review from rhshah March 21, 2024 21:36
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rashmi, a suggested change and a few questions. Overall, things look pretty good!

modules/msk/genomenexus/vcf2maf/main.nf Outdated Show resolved Hide resolved
modules/msk/genomenexus/vcf2maf/main.nf Outdated Show resolved Hide resolved
modules/msk/genomenexus/vcf2maf/main.nf Show resolved Hide resolved
modules/msk/genomenexus/vcf2maf/main.nf Outdated Show resolved Hide resolved
modules/msk/genomenexus/vcf2maf/meta.yml Show resolved Hide resolved
@rnaidu rnaidu requested review from johnoooh and buehlere April 4, 2024 15:36
modules/msk/genomenexus/vcf2maf/main.nf Outdated Show resolved Hide resolved
modules/msk/genomenexus/vcf2maf/main.nf Outdated Show resolved Hide resolved
@anoronh4 anoronh4 linked an issue May 2, 2024 that may be closed by this pull request
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnaidu a new general note is that we'd like to switch to using this version of vcf2maf: https://github.com/genome-nexus/vcf2maf-lite. Let me know if I can help.

@rnaidu rnaidu requested a review from buehlere May 13, 2024 17:43
…branch. subworkflow will be built off of here
@buehlere buehlere requested a review from nikhil June 26, 2024 19:50
- "genomenexus":
description: "DSL2 module to perform an annotation of MAF file type using the genomenexus suite of conversion and annotation tools."
homepage: "https://github.com/genome-nexus/genome-nexus-annotation-pipeline/"
documentation: "https://github.com/genome-nexus/.github/blob/main/profile/README.md"
Copy link
Collaborator

@nikhil nikhil Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update the description. The tool itself (genomenexus) is not a nextflow dsl2 module its just a java pipeline.
Also: you can maybe use this for the docs (https://docs.genomenexus.org/)

@rnaidu rnaidu requested review from nikhil and buehlere June 28, 2024 18:41
@rnaidu rnaidu force-pushed the feature/genome_nexus_final branch from 7001ebc to dc38308 Compare June 28, 2024 19:03
@rnaidu rnaidu force-pushed the feature/genome_nexus_final branch from a72c6c7 to dc38308 Compare July 11, 2024 14:53
@rnaidu rnaidu merged commit 138908f into develop Jul 11, 2024
19 checks passed
@rhshah rhshah deleted the feature/genome_nexus_final branch July 11, 2024 17:16

cat <<-END_VERSIONS > versions.yml
"${task.process}":
genomenexus: 'annotation pipeline version 1.0.3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnaidu i know this is merged by we would need to update these versions


cat <<-END_VERSIONS > versions.yml
"${task.process}":
genomenexus: 'annotation pipeline version 1.0.3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnaidu here as well

label 'process_low'

container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'ghcr.io/msk-access/genomenexus:vcf2maf_lite':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnaidu Also for both containers, is genome nexus team not hosting them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Module vcf2maf
4 participants