Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non-key, non @mandatory fields optional attributes #5

Open
mattreddy3 opened this issue Nov 7, 2020 · 2 comments
Open

Make non-key, non @mandatory fields optional attributes #5

mattreddy3 opened this issue Nov 7, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattreddy3
Copy link

Another one for whenever you are working on the library again - would be nice to have all fields be optional except for key fields and those with the @mandatory annotation

@mrbandler mrbandler self-assigned this Nov 27, 2020
@mrbandler mrbandler added the enhancement New feature or request label Nov 27, 2020
@mrbandler
Copy link
Owner

Hi @mattreddy3,

I was always torn on which CDS basis I create optional fields or not.
As I am currently planning a re-write, which will include a configuration file for further customizations of the generated Typescript code, I will add it there. I hope you can live with the current state of the project until I finished the rewrite.

@mattreddy3
Copy link
Author

Yes, for sure good for me as-is. Just thought it might be a good addition.
thanks!

p.s. I would love to help but as I am just getting a handle on typescript as it is, I can't do a whole lot outside of give feedback as a user. That said, let me know if you need anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants