Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for JS::Stencil #63

Open
arai-a opened this issue Aug 23, 2022 · 2 comments
Open

Add example for JS::Stencil #63

arai-a opened this issue Aug 23, 2022 · 2 comments

Comments

@arai-a
Copy link
Contributor

arai-a commented Aug 23, 2022

as mentioned in #60 review comment, clone functionality is removed and that needs to be rewritten with JS::Stencil APIs.

I'll look into adding examples

@kulsoomzahra
Copy link

@arai-a Can you please point me to a good first issue or maybe somewhere that can be a nice
place to start for first-time contributors? Thank you so much!

@arai-a
Copy link
Contributor Author

arai-a commented Sep 29, 2022

Hi, welcome.
This is also good-first-issue, in term of the complexity of the API.

APIs to cover in this example:

similar unit test is stored in the SpiderMonkey source: testStencil.cpp

Here's the list of things to do:

Prerequisite:

  • Clone this repository (esr91 branch) and build examples

This issue:

  • Add a new source file in examples directory, copying hello.cpp
  • Add the source file to meson.build file
  • Add #include <js/experimental/JSStencil.h> and some other public headers to the example file
  • Rewrite the code around JS::Evaluate with JS::Stencil-related APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants