Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopush integration tests don't run against release builds (STRICT_LOG_COUNTS=false) #513

Open
data-sync-user opened this issue Nov 7, 2023 · 1 comment

Comments

@data-sync-user
Copy link
Collaborator

The integration test run in CI currently runs against a debug build. This disables its STRICT_LOG_COUNTS var which was built to ensure the number of log messages aren’t larger than we expect.

These log counts should be enforced in CI. It might not be feasible to run them against a release build (which will add to our CI build times): we could at least configure the debug build to produce the same log output as release and check that instead. This would require altering the test’s disabling of STRICT_LOG_COUNTS in debug builds.

┆Issue is synchronized with this Jira Bug

@data-sync-user
Copy link
Collaborator Author

➤ Taddes Korris commented:

Hey Philip Jenvey ! What are your thoughts on us proceeding on this one? Would you like me to land a patch that adjusts the STRICT_LOG_COUNTS config? We can discuss this one further next week as well. Perhaps we can do a few test builds to see what the output looks like and what impact it has on the build times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant