Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting already handled by Crowdsec. #1

Open
he2ss opened this issue Aug 16, 2024 · 1 comment
Open

Whitelisting already handled by Crowdsec. #1

he2ss opened this issue Aug 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@he2ss
Copy link

he2ss commented Aug 16, 2024

Hi @mostafahussein,

First of all, thank you for this contribution 👍.
I saw some improvements that can be made to improve the remediation component. The first one is the whitelisting; it's only IPv4 compliant.
FYI, Crowdsec is already dealing with whitelists. I understand that you need to have it in the plugin directly; maybe if you handle ipv6, it would also be a good improvement :).

@mostafahussein
Copy link
Owner

Hi @he2ss,

Thanks for the suggestion! I'll definitely consider adding IPv6 support 👍🏼.

The idea for the whitelist option actually came from a demo I used while writing the blog post. In the demo, CrowdSec was whitelisting the internal IPs by default. Instead of modifying that, I created a separate subnet that wasn't whitelisted by crowdsec/whitelists. That got me thinking, why not offer this as an option for others who might find it useful?
It could be particularly helpful if someone wants to whitelist specific IPs at the API Gateway/Service level or if they're just starting out with CrowdSec and want an extra layer of control.

Thanks again for your suggestion and please feel free to contribute any time 🎉

@mostafahussein mostafahussein added the enhancement New feature or request label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants