Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEON code does not build on armv7 #171

Closed
clausecker opened this issue May 22, 2023 · 2 comments
Closed

NEON code does not build on armv7 #171

clausecker opened this issue May 22, 2023 · 2 comments

Comments

@clausecker
Copy link
Contributor

The NEON code in your project appears to use intrinsics that only exist on AArch64. However, you merely check for the presence of NEON extensions, also trying to build this code on AArch32 (aka arm, armv7). Please check this and either remove the intrinsics in question or change the code so it is only build on AArch64. Here are the offending intrinsics I found in my first pass (both in StringView.cpp):

vshrn_high_n_u16
vaddvq_u8
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue May 25, 2023
 - add CPU detection code for armv7, aarch64
   (armv7 is still broken for other reasons)
 - add missing FreeBSD support code for executableLocation()
 - hook up test suite

See also:	mosra/corrade#171
Approved by:	yuri (maintainer)
Differential Revision: https://reviews.freebsd.org/D40202
@mosra mosra added this to the 2023.0a milestone Dec 10, 2023
@mosra
Copy link
Owner

mosra commented Dec 10, 2023

Should be fixed in 0169e21, sorry it took such a massive amount of time.

I also grabbed your patches from the commit referenced above and pushed them as d99afc1 and be614b9 -- thank you for these! I attempted to do some blind polishing but currently have no automated way to check that they work, so hopefully I didn't break anything. Let me know if I did, I'll try to be more responsive this time.

(Tangential, ideally I'd have some sort of a FreeBSD CI build (and a Big-Endian build, and something where I can test 32-bit ARM...), but CircleCI doesn't support those, and my attempts to build those in a VM failed spectacularly: #166)

@mosra mosra closed this as completed Dec 10, 2023
@clausecker
Copy link
Contributor Author

Thank you for the update! @yurivict is the one maintaining the port and will probably update it once you release a new version. I'll see if I can get your changes test-built on armv7 in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants