Fixed upload subtitle language selection duplicated languages #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-oki
changed the title
anderson-oki
commented
Sep 19, 2024
Comment on lines
+82
to
+95
| uniqWith( | ||
| languages, | ||
| (a, b) => a.code2 === b.code2 && a.hi === b.hi && a.forced === b.forced, | ||
| ), | ||
| (v) => { | ||
| const suffix = cond([ | ||
| [(v: Language.Info) => v.hi || false, () => "(Hearing Impaired Only)"], | ||
| [(v) => v.forced || false, () => "(Forced Only)"], | ||
| [() => true, () => "(Normal or Hearing Impaired)"], | ||
| ]); | ||
|
|
||
| return `${v.name} ${suffix(v)}`; | ||
| }, | ||
| (v) => BuildKey(v.code2, v.hi, v.forced), |
There was a problem hiding this comment.
Instead we should replace it with 2 dropdowns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we use the language profile created by the user to retrieve the languages, there could be duplicated languages being added such as Forced, and HI, since Forced and HI are checkboxes on the Upload. form, we should remove any languages where the code2 are duplicated.
The issue is being fixed for both Series and Movies. Ideally in the future we should discuss again to do not allow duplicated records in the Contact profile.
Closes #2670
The Checkboxes that were confusing before are now single selection dropdown for Hi and Forced in both Movies or Series: