Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate IDs in languages profile items #2667

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fixed duplicate IDs in languages profile items #2667

merged 4 commits into from
Sep 25, 2024

Conversation

morpheus65535
Copy link
Owner

@morpheus65535 morpheus65535 commented Sep 17, 2024 •
edited
Loading

  • Fixed duplicate languages profile items IDs for those without cutoff and implemented health issue notifications for those with cutoff.
  • Fix frontend to be able to edit remaining languages profiles, reassign IDs and confirm cutoff before hitting save button.

@morpheus65535
Fixed duplicate languages profile items IDs for those without cutoff …
97f3f40 
…and implemented health issue notifications for those with cutoff.
JaiZed
JaiZed approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@JaiZed JaiZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me.

@morpheus65535
Copy link
Owner Author

@anderson-oki sanitize should be run only if the profile has duplicate items ID, right?

@anderson-oki
Copy link
Collaborator

@anderson-oki sanitize should be run only if the profile has duplicate items ID, right?

Not really, it also sanitize tag null to undefined and we need that forever.

@morpheus65535
Copy link
Owner Author

@anderson-oki sanitize should be run only if the profile has duplicate items ID, right?

Not really, it also sanitize tag null to undefined and we need that forever.

Is cutoff preserve on edit if we assign new id to items?

@anderson-oki
Fixed profile item regenerate id when not duplicated (#2681)
d4c5679 
* Fixed profile item regenerate id when not duplicated

* refactor: Preserve immutability
@morpheus65535 morpheus65535 merged commit c11bdf3 into development Sep 25, 2024
2 checks passed
@morpheus65535 morpheus65535 deleted the duplicate_langs_profile_ids branch September 25, 2024 19:33
@morpheus65535 morpheus65535 mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderson-oki anderson-oki anderson-oki approved these changes

@JaiZed JaiZed JaiZed approved these changes

Assignees

@morpheus65535 morpheus65535

@anderson-oki anderson-oki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morpheus65535 @anderson-oki @JaiZed