Fixed PWA not registered #2566
Merged
Fixed PWA not registered #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-oki
force-pushed
the
feature/add-vite-pwa
branch
from
72b4759
to
aa0bbd0
Compare
anderson-oki
requested review from
morpheus65535
and removed request for
morpheus65535
|
@morpheus65535 Can you check if you want to update the screenshots with something specific? They will be used for Rich PWA install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2562
Manually maintaining the service worker, updates, manifest.json, injection it is too much effort, and we don't need anything complex, even tho, everything can be supported later on by using Vite Pwa regardless on how complex we want to go.
I added the minimum required to allow the installation of the PWA via Android, iOS, and Desktop browsers with support of cache invalidation once Bazarr is restarted to get the latest frontend changes without the need to refresh the page.
Added Support for Rich Installation:
Removed
manifest.json