Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update userguide matrix via element #2364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HardenedSteel
Copy link
Contributor

@HardenedSteel HardenedSteel commented Aug 30, 2024

IOS screenshots are missing

will close #2361

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e7d9957
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/66d4ec20f9a35d0008ff1fd9
😎 Deploy Preview https://deploy-preview-2364--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof
Copy link
Collaborator

plowsof commented Aug 30, 2024

its nice to see inline srcset however what are we doing here? future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly? if we had translations set up we would be presenting translators with alot of raw html. replacing the screenshots with new avifs is perfectly acceptable.

I'd much rather see your efforts and knowledge put into how we should be displaying images in astro / discussing fallbacks/image types with the new designer/dev.

@HardenedSteel
Copy link
Contributor Author

future proofing -site for a time when jpgxl's are more widely supported when its going to be replaced shortly?

yes, JPEG XL has more features and looks more freer format*, that's why I preferred over AVIF.

In my testings:
AVIF performing better for more lossy pictures
JPEG XL performing better for less (or lossless) pictures

there's more detailed comparison: https://cloudinary.com/blog/time_for_next_gen_codecs_to_dethrone_jpeg

@HardenedSteel
Copy link
Contributor Author

converting to ready for review, IOS screenshots can be fixed with different PR

@plowsof
Copy link
Collaborator

plowsof commented Sep 15, 2024

NACK - remove the srcset busy work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update join Monero core team Matrix server guide; screenshots outdated
2 participants