Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The symbol value from the fields "Alternative titles; symbols" and "Included Title(s); symbols" is missing #118

Open
3 tasks
twhetzel opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working omim

Comments

@twhetzel
Copy link
Contributor

twhetzel commented Jul 24, 2024

View the information at: https://omim.org/entry/618983?search=les&highlight=les

The string LES that is a symbol for the Alternative title and appears to be in the "mimTitles" file is not added into the omim.owl file. The field could be added as a synonym with type annotation abbreviation.

Similar finding for symbols from "Included Title(s); symbols". See https://omim.org/entry/618856?search=618856&highlight=DEND1

Edit by Joe:
Trish to decide if we really want to add 'included' symbols as synonyms.

Sub-tasks

@twhetzel twhetzel changed the title The symbol value from the field "Alternative titles; symbols" is missing The symbol value from the fields "Alternative titles; symbols" and "Included Title(s); symbols" is missing Jul 24, 2024
@joeflack4
Copy link
Contributor

It looks like it may not be pulling stuff after the ; in alternative titles.

@joeflack4 joeflack4 self-assigned this Jul 25, 2024
@joeflack4 joeflack4 added bug Something isn't working omim labels Jul 25, 2024
@joeflack4
Copy link
Contributor

joeflack4 commented Aug 29, 2024

Need to double check, "Alternative titles; symbols" on the web site seems to always follow this syntax:
SINGLE LABEL; SINGLE SYMBOL

Example:

Alternative titles; symbols
LEWIS BLOOD GROUP SYSTEM; LES

There can be multiple "Alternative titles; symbols", each on a different line.

Questions

  • 1. Label cardinality: Could there ever be 0 or 2+ per line? (probably not)
    • there'd be no way to tell and it'd make no sense. docs don't reflect that. indicate multiple symbols. field also has title in singular but symbols in potentially plural.
  • 2. Symbol cardinality: Could there ever be 0 or 2+ per line?
    • A: There can be 0 symbols. There can theoretically be more. for some fields there are.
  • 3. Alternative patterns?: Is it only ever this pair of label and symbol, or could there be additional ; with additional synonyms of a sort?
    • they just come in title/symbol pairs. Multiple titles/symbol pairs delimited by ;;
  • 4. Symbol synonym_type: Should we interpret the symbols always as abbreviations? Or are they sometimes acronyms? Or are they sometimes not quite acronyms or abbreviations, but abbreviation/acronym-like?
    • I think they're more than abbreviations but for Mondo purposes, at least when it comes to synonym type, we're considering them as such.

Some sub-tasks for Joe

  • Answer questions
  • Check mimTitles.txt syntax: On the web page they're line break delimited if multiple title symbol pairs. But what about the data file? I'm guessing they appear on the same row. How are label/symbol pairs delimited? Maybe by ,?
    • delimited by ;;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working omim
Projects
None yet
Development

No branches or pull requests

2 participants