Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Fields are Placed Randomly in modrinth.index.json When Exporting #2510

Open
3 tasks done
UltimatChamp opened this issue Oct 15, 2024 · 4 comments
Open
3 tasks done
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@UltimatChamp
Copy link

UltimatChamp commented Oct 15, 2024

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.8.8

Describe the bug

It looks like the sha1 and sha512 fields are placed, randomly, while exporting a modpack. Same is the case for client-server and the minecraft-loader fields. The image shows a diff between two different, simultaneous exports.

@Norbiros
Copy link
Contributor

I don't think this is really an issue. We use hashmaps to store envs/hashes, which means that fields may be unordered when serialized. JSON objects don't require a specific order, and there are probably many other places that also have "random" order

@UltimatChamp
Copy link
Author

Yeah, but it's pretty annoying if you upload-n-update files to GitHub.
I'm sure that at some point, it did not happen in Modrinth App.

@Norbiros
Copy link
Contributor

We could sort it here or use a btree, but there may be other places with a 'random' order. Have you noticed any others?

@UltimatChamp
Copy link
Author

These

It looks like the sha1 and sha512 fields are placed, randomly, while exporting a modpack. Same is the case for client-server and the minecraft-loader fields. The image shows a diff between two different, simultaneous exports.

Oh, yeah! The project files are also randomly placed. So, maybe it's time to fix #1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

2 participants