Feat(plot_centers): add plot_centers support to PlotMapView and PlotCrossSection #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rossSection fixes and updates included with feature: * filter very short/small intersection segments from cross-sectional plotting routine * sort and assure vertex order is correct for intersected cross-sectional segments * improve geometry.project_point_onto_xc_line() calculation routine. * update reproject_modpath_to_crosssection()
|
@wpbonelli, do you have any insight into the windows failures/have you seen this before? CI is failing on the Install modflow executables step with an error that states "python3 is not recognized ..." |
* add projctr attribute to PlotCrossSection for testing purposes
|
I think there may be a couple things going on... one being, GH evidently dropped some items from their API responses https://github.com/orgs/community/discussions/140079 when a token is present on the request. Easy enough to work around. Idk about the python not found issue. I will take a closer look later today |
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2318 +/- ##
=========================================
- Coverage 75.6% 74.3% -1.3%
=========================================
Files 294 294
Lines 59560 59677 +117
=========================================
- Hits 45073 44395 -678
- Misses 14487 15282 +795
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes and updates included with feature:
closes #2299