Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_model_files api call only gets the model #92

Open
ahmedhosny opened this issue Aug 30, 2018 · 3 comments
Open

get_model_files api call only gets the model #92

ahmedhosny opened this issue Aug 30, 2018 · 3 comments

Comments

@ahmedhosny
Copy link
Member

Should also get the pre and post processing - maybe the entire contrib_src?

@michaelschwier
Copy link
Member

I'm not sure if we should actually support this via the API. In the end, if someone really wants all the model related source, they could/should just download the repository.

@ahmedhosny
Copy link
Member Author

Agree - do you think we should remove this API method all together as it might be confusing?

@michaelschwier
Copy link
Member

I think we could actually remove it. The easiest way to get the full model source is using start.py, since it also downloads the trained-model(-weights) from a possibly external source. We should add this as recommended way to get the full model source in our documentation.

2nd easiest way is to download a release (if there is a release which might not be guaranteed for user contributed/hosted models)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants