Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling #22

Open
shanedsnyder opened this issue Mar 18, 2021 · 0 comments
Open

error handling #22

shanedsnyder opened this issue Mar 18, 2021 · 0 comments

Comments

@shanedsnyder
Copy link
Contributor

In GitLab by @shanedsnyder on Jun 5, 2018, 16:54

I took a quick glance, but don't see any logic related to error handling in the write_op and read_op chain stuff for Mobject.

For instance, it's not clear to me how we're supposed to handle errors that may arise in the middle of a longer chain of read_op/write_op requests. These functions that implement the various operations that can be performed in a write_op/read_op all return void values, so you can't explicitly return an error code. Given that, I guess each write_op/read_op just executes until completion, regardless of how many errors are encountered?

I think we need to add some functionality to allow for an explicit error number to be set on a write_op/read_op that causes the operation to abort and ACK back to the client? Otherwise, we won't know what specific error caused a long chain to fail or, worse, we may mask the fact than an error occurred at all (if a successful operation occurs after one that failed, overwriting it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant