Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adding doc folder and tightening makefile recipes for checking style #22

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

adam2392
Copy link
Member

PR Description

Addresses #20 and setting up docs folder.

We need to migrate to MNE to setup circleci for docs building, so it'll take a few iterations to make sure we got everything right w/o errors.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@adam2392
Copy link
Member Author

FYI: @mscheltienne

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #22 (9d68165) into main (c1eaedf) will not change coverage.
The diff coverage is 95.45%.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files           4        4           
  Lines         379      379           
=======================================
  Hits          368      368           
  Misses         11       11           
Impacted Files Coverage Δ
mne_icalabel/features.py 97.88% <90.90%> (ø)
mne_icalabel/network.py 100.00% <100.00%> (ø)
mne_icalabel/utils.py 92.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1eaedf...9d68165. Read the comment docs.

@adam2392
Copy link
Member Author

Gonna merge to make the dev process easier w/ the Makefile recipes.

@adam2392 adam2392 merged commit 7bf7956 into main Apr 28, 2022
@adam2392 adam2392 deleted the doc branch April 28, 2022 20:36
Comment on lines +9 to +16
* ``mne`` (>=1.0)
* ``numpy`` (>=1.14)
* ``scipy`` (>=1.5.0)
* ``joblib`` (>=1.0.0)
* ``scikit-learn`` (>=1.1)
* ``torch`` (for running pytorch neural networks)
* ``python-picard`` (for running ICA)
* ``matplotlib`` (optional, for using the interactive data inspector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail for now, but this should be updated when #16 is resolved. I'm guessing matplotlib and joblib are not required?

Comment on lines +1 to +22
% Encoding: UTF-8
@article{AvantsEtAl2008,
author = {Avants, Brian B. and Epstein, Charles L. and Grossman, Murray C. and Gee, James C.},
doi = {10.1016/j.media.2007.06.004},
journal = {Medical Image Analysis},
number = {1},
pages = {26-41},
shorttitle = {Symmetric Diffeomorphic Image Registration with Cross-Correlation},
title = {Symmetric Diffeomorphic Image Registration with Cross-Correlation: Evaluating Automated Labeling of Elderly and Neurodegenerative Brain},
volume = {12},
year = {2008}
}

@book{OppenheimEtAl1999,
address = {Upper Saddle River, NJ},
edition = {2 edition},
title = {Discrete-{Time} {Signal} {Processing}},
isbn = {978-0-13-754920-7},
publisher = {Prentice Hall},
author = {Oppenheim, Alan V. and Schafer, Ronald W. and Buck, John R.},
year = {1999}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah good catch, I need to replace this with the ICLabel publication and add to the docstring in #21 for label_ic and the ICLabelNet.


This is the application programming interface (API) reference
for classes (``CamelCase`` names) and functions
(``underscore_case`` names) of MNE-Connectivity, grouped thematically by analysis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One MNE-Connectivity reference that slipped by ;)

@@ -0,0 +1,24 @@
[tool.black]
line-length = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it says 115 in .flake8. Normal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure tbh. It might be needed to not error out, but I'll do some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants