Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create About Page #125

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Create About Page #125

wants to merge 22 commits into from

Conversation

UtkarshKr007
Copy link
Member

@UtkarshKr007 UtkarshKr007 commented Jul 30, 2020

Closes: #9 and Closes: #182

Shawn Reuter and others added 5 commits July 25, 2020 17:34
Added info icon to sidebar

Co-authored-by: Utkarsh Kumar <[email protected]>
Co-authored-by: Utkarsh Kumar <[email protected]>
Co-authored-by: Paul Friederichsen <[email protected]>
The gatsby-source-github-api doesn't support retrieving contributors
yet. The closest thing it can give is a list of collaborators which are different, so I used a different plugin.
I also filter dependabot out in the GraphQL query. I initally had a
regex query that fitlered out any login with
"bot" in it, but that could theoretically catch future contributors
whose login contain the words 'bot'.
I didn't use the alt prop, because in local testing it didn't show to
replace image with first letter of alt vale as material ui docs say it
should.
src/pages/about.js Outdated Show resolved Hide resolved
src/pages/about.js Outdated Show resolved Hide resolved
src/pages/about.js Outdated Show resolved Hide resolved
src/pages/about.js Outdated Show resolved Hide resolved
Copy link
Member

@floogulinc floogulinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, just a few concerns.

src/pages/about.js Outdated Show resolved Hide resolved
Comment on lines 71 to 73
Pollinator Facts website was created alongside the <a href="https://buzzabout.app">Buzz About</a> participatory simulation game to
teach people about native pollinators of Minnesota. This website holds many interesting tidbits as well beautiful pictures of pollinators, their food, homes
and habits.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to work on this blurb. I don't know if we want to link to Buzz About here.

src/pages/about.js Outdated Show resolved Hide resolved
src/pages/about.js Outdated Show resolved Hide resolved
src/pages/about.js Outdated Show resolved Hide resolved
gatsby-config.js Outdated Show resolved Hide resolved
Comment on lines +172 to +173
The images used for facts belong to their respective owners. Clicking the info button on the bottom right of a fact
presents the information and links to the image owners as well as the license under which the image is published.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely need to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About page contributors Create about page and acknowledge ENRTF funding
2 participants