Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParamSet might be too rich for some usecases #287

Open
berndbischl opened this issue Jun 27, 2020 · 4 comments
Open

ParamSet might be too rich for some usecases #287

berndbischl opened this issue Jun 27, 2020 · 4 comments

Comments

@berndbischl
Copy link
Sponsor Member

berndbischl commented Jun 27, 2020

Eg in bbotk we only use the PS to describe domain and codomains.
But we now have defaults in there, and also "values"
(which have both no place there)

> obj
<ObjectiveRFun:function>
Domain:
ParamSet: 
   id    class lower upper levels     default value
1: x1 ParamDbl    -1     1        <NoDefault>      
2: x2 ParamDbl    -1     1        <NoDefault>      
Codomain:
ParamSet: 
   id    class lower upper levels     default value
1:  y ParamDbl  -Inf   Inf        <NoDefault>      

maybe we should make that more configurable of have a hierarchies of classes

@jakob-r
Copy link
Sponsor Member

jakob-r commented Jun 29, 2020

Do you really want to introduce a "sparse" parent class just to have a more tidy output? I don't know the OO lingo but introducing a class that is designed to have just one child seems to be overengeneering. I vote for close.

@berndbischl
Copy link
Sponsor Member Author

No, I never said that, the "print" is only a summary. Just think about it like this:
You now use a PS for a domain of a function. A user writes into "values".
Thats completely ignored. Thats at least weird?

I don't know the OO lingo but introducing a class that is designed to have just one child seems to be overengeneering.

that rule doesn't exist

@jakob-r
Copy link
Sponsor Member

jakob-r commented Jun 30, 2020

You now use a PS for a domain of a function. A user writes into "values".
Thats completely ignored. Thats at least weird?

Does it fall into the category: "The user can do stupid things, and we don't care."?

@berndbischl
Copy link
Sponsor Member Author

not really, as that API is publicly offered. I am not saying it is the most urgent issue, but i would maintain that this is not optimal....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants