Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondEqual should give an error when constructed with vector length > 1 #261

Open
mb706 opened this issue Jan 9, 2020 · 2 comments
Open
Assignees
Labels
Tag: Contrib (prepared) A contributor should be able to solve this. The issue discussion contains enough info and support.
Milestone

Comments

@mb706
Copy link
Contributor

mb706 commented Jan 9, 2020

CondEqual$new(c("b", "c")))

should throw an error

@mb706 mb706 added the Tag: Contrib (prepared) A contributor should be able to solve this. The issue discussion contains enough info and support. label Feb 12, 2020
@berndbischl
Copy link
Sponsor Member

not necessarily, unfortunately. it basically depends on whether we allow the parent param to be ParamUty (hence to use deps in learners).

if we allow that, such a param could have a vector-valued setting. i guess we don't want that, but this then need to make clear asserted

@mb706
Copy link
Contributor Author

mb706 commented Aug 21, 2020

In that case the CondEqual test function is broken (should be identical instead of ==)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Contrib (prepared) A contributor should be able to solve this. The issue discussion contains enough info and support.
Projects
None yet
Development

No branches or pull requests

4 participants