Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect learner textmodel_nb from package quanteda.textmodels #158

Open
10 tasks
andreassot10 opened this issue Sep 23, 2020 · 0 comments
Open
10 tasks

Connect learner textmodel_nb from package quanteda.textmodels #158

andreassot10 opened this issue Sep 23, 2020 · 0 comments

Comments

@andreassot10
Copy link

Before making this request, make sure that

  1. The learner is not maintained in a third party repository (listed in the Table of all additional Learners), and
  2. There is no other open or closed issue on this learner in this tracker.

Checklist before requesting a review

  • Run styler::style_pkg(style = styler::mlr_style) (install pat-s/styler@mlr-style if not yet done)

  • Run lintr::lint_package() and fix all issues.

  • Run usethis::use_tidy_description() to format the DESCRIPTION file.

  • Check that the learner package name is all lower case, e.g. mlr3learners.partykit.

  • Ensure that there are not leftover of <package>, <algorithm> or <type> within the learner repo.

  • Ensure that the "Parameter Check" passed in the CI (both for the train and predict functions)

  • Ensure that "R CMD check" passed in the CI.

  • Check that your learners upstream package is not listed in the "Imports" but in the "Suggests" section within the DESCRIPTION file.

  • If you changed any parameter defaults: Did you document the change (reason and new default) in the help page of the respective learner?

  • Open a Pull Request in the mlr3learners repo to add your learner to the list of "In Progress" learners. Once approved, it will be moved to the "Approved" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant