Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.1 BERT] Update reference and rules to allow clipnorm-after-reduce #432

Open
johntran-nv opened this issue Mar 25, 2021 · 0 comments
Open
Labels

Comments

@johntran-nv
Copy link
Contributor

In v1.0, we discovered after code freeze that the reference does clipnorm-before-reduce. Mathematically, that is not as good as clipnom-after-reduce, but since it was after code freeze, we decided to allow either, but not let submitters take advantage of perf optimizations from clipnorm-after-reduce.

For v1.1, we should change the reference before code freeze, and allow optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant