From 88217c555e8bb15a732216ee1a1e90bb2ca2bfaa Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Tue, 18 Jul 2023 10:53:24 -0700 Subject: [PATCH] CodeQL suppressions --- src/vs/base/common/htmlContent.ts | 2 +- .../contrib/notebook/browser/view/renderers/webviewPreloads.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/base/common/htmlContent.ts b/src/vs/base/common/htmlContent.ts index 9cefc0e56a490..10e25c9c9e32f 100644 --- a/src/vs/base/common/htmlContent.ts +++ b/src/vs/base/common/htmlContent.ts @@ -60,7 +60,7 @@ export class MarkdownString implements IMarkdownString { this.value += escapeMarkdownSyntaxTokens(this.supportThemeIcons ? escapeIcons(value) : value) .replace(/([ \t]+)/g, (_match, g1) => ' '.repeat(g1.length)) .replace(/\>/gm, '\\>') - .replace(/\n/g, newlineStyle === MarkdownStringTextNewlineStyle.Break ? '\\\n' : '\n\n'); + .replace(/\n/g, newlineStyle === MarkdownStringTextNewlineStyle.Break ? '\\\n' : '\n\n'); // CodeQL [SM02383] The Markdown is fully sanitized after being rendered. return this; } diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts index 25dab44de718b..ab020cf411b91 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts @@ -2536,7 +2536,7 @@ async function webviewPreloads(ctx: PreloadContext) { this._content = { preferredRendererId, preloadErrors }; if (content.type === 0 /* RenderOutputType.Html */) { - const trustedHtml = ttPolicy?.createHTML(content.htmlContent) ?? content.htmlContent; + const trustedHtml = ttPolicy?.createHTML(content.htmlContent) ?? content.htmlContent; // CodeQL [SM03712] The content comes from renderer extensions, not from direct user input. this.element.innerHTML = trustedHtml as string; } else if (preloadErrors.some(e => e instanceof Error)) { const errors = preloadErrors.filter((e): e is Error => e instanceof Error);