Maker Academy Graduate issue: IE7 javascript problem

[jsugarman]

The following report was received from a user and has been confirmed as an issue for, at least, Windows XP, Internet Explorer 7 users:

Problem report:

Browser: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; InfoPath.1; .NET4.0C; .NET4.0E) Reported: 2016-07-29T14:09:10Z

What they were trying to do:

“Add my team”

What happened:

“When scrolling down after the list of teams within OPG Operations, the list didn't scroll, which means I couldn't select my team (Sirius Training Admin Team)”

NOTE: This is when editing the profile and choosing the users team

To resolve you will need to setup virtualbox to replicate the users environment. I would recommend using windows 7, IE9/10 and then using the dev tools to emulate IE7. see README.md for instructions on this.

[oceansize]

I think the original issue is caused by an IE7 bug, because adding position: relative to the ul in app/views/shared/_org_browser_level_subgroups.html.haml restores the ability to scroll vertically. However, it then breaks the horizontal motion between sub-teams, introducing horizontal scrollbars and upsetting the alignment (both in IE7 on Windows XP and Chrome 54 on OS X).

At this point I should ask what the protocol for MoJ is in such situations. Perhaps you'd prefer some sort of polyfill for the older browsers etc? Alternatively it might be desirable to use a conditional stylesheet for a more basic navigation device with older browsers? Or there might just be a super simple fix that I'm missing...

[jsugarman]

Thanks Roi, thats great - love the gif

I'm not a FE developer specialist but ideally there would be a simple hack.
if conditional styling (via the peoplefinder-ie7.css.scss file) won't do it
then i imagine a javascript polyfill will be needed. If you are interested
you could try creating am assets/javascripts/peoplefinder-ie7.js file and
apply any differences in there - and precompile it by adding to the
config/initializers/assets.rb Rails....precompile array.

Let me know how you get along.

On 26 October 2016 at 23:43, Roi Driscoll [email protected] wrote:

I think the original issue is caused by an IE7 bug, because adding position:
relative to the ul in app/views/shared/org_browser
level_subgroups.html.haml restores the ability to scroll vertically.
However, it then breaks the horizontal motion between sub-teams,
introducing horizontal scrollbars and upsetting the alignment (both in IE7
on Windows XP and Chrome 54 on OS X).

[image: broken_nav]
https://cloud.githubusercontent.com/assets/2243253/19747674/f82769be-9bd4-11e6-9274-c3cccf11896c.gif

At this point I should ask what the protocol for MoJ is in such
situations. Perhaps you'd prefer some sort of polyfill for the older
browsers etc? Alternatively it might be desirable to use a conditional
stylesheet for a more basic navigation device with older browsers? Or there
might just be a super simple fix that I'm missing...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#370 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGsP6ShBeU31E5LMboDUtAPJ0X0x1aXTks5q39eHgaJpZM4KUpVm
.

Joel Sugarman - Developer

[oceansize]

Apologies this is taking a while to get to - work has been crazy but I'm looking to get some time on it this weekend fingers crossed!

[jsugarman]

no problem Roi.

On 11 November 2016 at 09:44, Roi Driscoll [email protected] wrote:

Apologies this is taking a while to get to - work has been crazy but I'm
looking to get some time on it this weekend fingers crossed!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#370 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGsP6cBMn3Zv6Jccmot0mKdZ1HivobaRks5q9DjlgaJpZM4KUpVm
.

Joel Sugarman - Developer