From 5bcb37901c60463b27e1211e0f68295f213b19e6 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Mon, 11 Mar 2024 23:24:46 +0100 Subject: [PATCH] Use crypto.GenerateRandomBytes instead of doing it by hand This makes the code a bit shorter, and properly handle cryptographic error conditions. --- internal/config/options.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/internal/config/options.go b/internal/config/options.go index dc3d7063e29..483192f9946 100644 --- a/internal/config/options.go +++ b/internal/config/options.go @@ -4,12 +4,12 @@ package config // import "miniflux.app/v2/internal/config" import ( - "crypto/rand" "fmt" "sort" "strings" "time" + "miniflux.app/v2/internal/crypto" "miniflux.app/v2/internal/version" ) @@ -171,9 +171,6 @@ type Options struct { // NewOptions returns Options with default values. func NewOptions() *Options { - randomKey := make([]byte, 16) - rand.Read(randomKey) - return &Options{ HTTPS: defaultHTTPS, logFile: defaultLogFile, @@ -242,7 +239,7 @@ func NewOptions() *Options { metricsPassword: defaultMetricsPassword, watchdog: defaultWatchdog, invidiousInstance: defaultInvidiousInstance, - proxyPrivateKey: randomKey, + proxyPrivateKey: crypto.GenerateRandomBytes(16), webAuthn: defaultWebAuthn, } }