Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate the OTEL breakage #4534

Closed
jhrozek opened this issue Sep 18, 2024 · 2 comments · Fixed by #4582
Closed

investigate the OTEL breakage #4534

jhrozek opened this issue Sep 18, 2024 · 2 comments · Fixed by #4582
Assignees
@blkt

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Sep 18, 2024

We've had issues lately with otel upgrades. This issue is filed to track that we spent time investigating where the issue is and hopefully record the outcome.

Assigning to @blkt who already spent time doing that but -- @blkt please don't feel pressured to work on this unless you already planned on.
@blkt
Copy link
Contributor

blkt commented Sep 19, 2024 •
edited
Loading

I managed to narrow down the issue to some extent and wrote a minimal script to reproduce.
https://github.com/blkt/panicrepro
I also opened an issue in the repo that I guess is responsible for the bug, although I'm not 100% sure.
signalfx/splunk-otel-go#3430

I'll park this issue until we get news from the maintainers.

@blkt
Copy link
Contributor

blkt commented Sep 20, 2024

This is confirmed as a regression on otel libraries.
open-telemetry/opentelemetry-go#5828

We'll probably have to close all PRs from dependabot for those libraries until a new version is released, as it looks like there's no workaround to the problem.

@blkt blkt closed this as completed Sep 20, 2024
blkt added a commit that referenced this issue Sep 30, 2024
@blkt
Test otel instrumentation for panics.
3a34b21 
This change adds a test that tries to limit runtime panics in staging
by checking some known cases that we encountered
recently. Unfortunately, testing cannot be extensive, but should
prevent us from merging broken PRs from dependabot.

Fixes #4534
@blkt blkt mentioned this issue Sep 30, 2024
Merged
10 tasks
blkt added a commit that referenced this issue Sep 30, 2024
@blkt
Test otel instrumentation for panics.
f52da37 
This change adds a test that tries to limit runtime panics in staging
by checking some known cases that we encountered
recently. Unfortunately, testing cannot be extensive, but should
prevent us from merging broken PRs from dependabot.

Fixes #4534
blkt added a commit that referenced this issue Sep 30, 2024
@blkt
Test otel instrumentation for panics. (#4582)
981dd74 
This change adds a test that tries to limit runtime panics in staging
by checking some known cases that we encountered
recently. Unfortunately, testing cannot be extensive, but should
prevent us from merging broken PRs from dependabot.

Fixes #4534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test otel instrumentation for panics. mindersec/minder
2 participants
@blkt @jhrozek