Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release version 0.3.0 to your chart repository #14

Open
GuyCarmy opened this issue Feb 12, 2022 · 1 comment
Open

Please release version 0.3.0 to your chart repository #14

GuyCarmy opened this issue Feb 12, 2022 · 1 comment

Comments

@GuyCarmy
Copy link

Hello, I have noticed @komljen updated the chart to use buzzfeed's sso version 3.0.0, and bumped the chart version to 0.3.0.
Last version released by @darioblanco to minddocdev.github.io is 0.2.11

can you release 0.3.0 so we can use it directly from your repo?

Thanks in advance

@bartmanus
Copy link

bartmanus commented Jan 29, 2023

Warning to future users: the master at HEAD/commit dafbd86 has a blocking bug so it should not be released as is.

The DEFAULT_PROVIDER_SLUG proxy env variable is misnamed. The v3.0.0 sso-proxy program configuration reads the environment variable UPSTREAM_DEFAULT_PROVIDER.

I did not rely on the comment in the linked file, but tested this with a forked chart.

Besides this chart bug, the chart templates are also not compatible with modern K8s APIs. Especially since 1.22 where Ingress v1beta1 was deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants