From f7f6dfa72d40c611c3a5e43f75e8cb2247d6418f Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Fri, 5 Jul 2024 14:25:02 +0800 Subject: [PATCH] enhance: enable setting properties during create database Signed-off-by: Wei Liu --- client/options.go | 12 ++++++++++++ examples/database/database.go | 2 +- go.mod | 2 +- go.sum | 2 ++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/client/options.go b/client/options.go index 0254dd7bc..78fd35866 100644 --- a/client/options.go +++ b/client/options.go @@ -309,6 +309,18 @@ type FlushOption func(*milvuspb.FlushRequest) type CreateDatabaseOption func(*milvuspb.CreateDatabaseRequest) +func WithDatabaseProperty(key, value string) CreateDatabaseOption { + return func(req *milvuspb.CreateDatabaseRequest) { + if req.Properties == nil { + req.Properties = make([]*commonpb.KeyValuePair, 0) + } + req.Properties = append(req.Properties, &commonpb.KeyValuePair{ + Key: key, + Value: value, + }) + } +} + type DropDatabaseOption func(*milvuspb.DropDatabaseRequest) type DescribeDatabaseOption func(*milvuspb.DescribeDatabaseRequest) diff --git a/examples/database/database.go b/examples/database/database.go index da84f505f..0f04ac8fd 100644 --- a/examples/database/database.go +++ b/examples/database/database.go @@ -20,7 +20,7 @@ func main() { clientDefault := mustConnect(ctx, cfg) defer clientDefault.Close() createCollection(ctx, clientDefault, "col1") - if err := clientDefault.CreateDatabase(ctx, "db1"); err != nil { + if err := clientDefault.CreateDatabase(ctx, "db1", client.WithDatabaseProperty("key1", "value1")); err != nil { log.Fatalf("create db1 failed, %+v", err) } dbs, err := clientDefault.ListDatabases(ctx) diff --git a/go.mod b/go.mod index 980c22af0..5989f7f28 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/go-faker/faker/v4 v4.1.0 github.com/golang/protobuf v1.5.2 github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 - github.com/milvus-io/milvus-proto/go-api/v2 v2.4.3 + github.com/milvus-io/milvus-proto/go-api/v2 v2.4.6-0.20240705061601-7a658711dc06 github.com/stretchr/testify v1.8.1 github.com/tidwall/gjson v1.14.4 github.com/x448/float16 v0.8.4 diff --git a/go.sum b/go.sum index 988bf02e1..85966c6a8 100644 --- a/go.sum +++ b/go.sum @@ -161,6 +161,8 @@ github.com/milvus-io/milvus-proto/go-api/v2 v2.3.4-0.20240430025921-135167be0694 github.com/milvus-io/milvus-proto/go-api/v2 v2.3.4-0.20240430025921-135167be0694/go.mod h1:1OIl0v5PQeNxIJhCvY+K55CBUOYDZevw9g9380u1Wek= github.com/milvus-io/milvus-proto/go-api/v2 v2.4.3 h1:KUSaWVePVlHMIluAXf2qmNffI1CMlGFLLiP+4iy9014= github.com/milvus-io/milvus-proto/go-api/v2 v2.4.3/go.mod h1:1OIl0v5PQeNxIJhCvY+K55CBUOYDZevw9g9380u1Wek= +github.com/milvus-io/milvus-proto/go-api/v2 v2.4.6-0.20240705061601-7a658711dc06 h1:b4ulIU5bNSxScgZ4eNb19Gdr6Xhv5pqaC2SOugFogao= +github.com/milvus-io/milvus-proto/go-api/v2 v2.4.6-0.20240705061601-7a658711dc06/go.mod h1:1OIl0v5PQeNxIJhCvY+K55CBUOYDZevw9g9380u1Wek= github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0= github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y= github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=