From 869db5292f5f98b8a7285862ae195c139fa0e82f Mon Sep 17 00:00:00 2001 From: congqixia Date: Tue, 16 Jul 2024 17:15:32 +0800 Subject: [PATCH] enhance: Sync autoID insert/upsert test cases (#788) Insert/Upsert behavior changes for milvus master branch. This PR updates some error message and error check for upsert with PKs when autoID=true. Signed-off-by: Congqi Xia --- test/testcases/insert_test.go | 2 +- test/testcases/upsert_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/testcases/insert_test.go b/test/testcases/insert_test.go index 43f0d6b22..672faff96 100644 --- a/test/testcases/insert_test.go +++ b/test/testcases/insert_test.go @@ -84,7 +84,7 @@ func TestInsertAutoIdPkData(t *testing.T) { // insert pkColumn, floatColumn, vecColumn := common.GenDefaultColumnData(0, common.DefaultNb, common.DefaultDim) _, errInsert := mc.Insert(ctx, collName, "", pkColumn, floatColumn, vecColumn) - common.CheckErr(t, errInsert, false, "can not assign primary field data when auto id enabled") + common.CheckErr(t, errInsert, false, "invalid parameter") // flush and check row count errFlush := mc.Flush(ctx, collName, false) diff --git a/test/testcases/upsert_test.go b/test/testcases/upsert_test.go index b1fa243f3..929ecd8ed 100644 --- a/test/testcases/upsert_test.go +++ b/test/testcases/upsert_test.go @@ -111,12 +111,12 @@ func TestUpsertAutoID(t *testing.T) { // upsert without pks _, floatColumn1, vecColumn1 := common.GenDefaultColumnData(0, 100, common.DefaultDim) _, err := mc.Upsert(ctx, collName, "", floatColumn1, vecColumn1) - common.CheckErr(t, err, false, "upsert can not assign primary field data when auto id enabled") + common.CheckErr(t, err, false, "invalid parameter") // upsert with pks pkColumn := entity.NewColumnInt64(common.DefaultIntFieldName, ids.(*entity.ColumnInt64).Data()[:100]) _, err = mc.Upsert(ctx, collName, "", pkColumn, floatColumn1, vecColumn1) - common.CheckErr(t, err, false, "upsert can not assign primary field data when auto id enabled") + common.CheckErr(t, err, true) } func TestUpsertVarcharPk(t *testing.T) {