Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Csharp document to milvus website and mark it as GA #70

Open
xiaofan-luan opened this issue Mar 23, 2024 · 4 comments
Open

Add Csharp document to milvus website and mark it as GA #70

xiaofan-luan opened this issue Mar 23, 2024 · 4 comments

Comments

@xiaofan-luan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Hi C# team. Thanks for the contribution and seems that the C# client almost catch up everything for Milvus 2.3(Milvus 2.4 is in release candidate but should be put into production soon.)

I'm proposing to put C# SDK into the one of the official supported SDKs and put into our document.

Describe the solution you'd like

  1. We need help for converting all the samples in the document into C#.
  2. Maybe some CI/CD to make sure milvus upgrade didn't broke the consistency.

Describe alternatives you've considered
Milvus maintainer team and doc team is glad to offer any help if necessary
Thanks for the awesome contribution!

@roji
Copy link
Collaborator

roji commented Mar 24, 2024

@xiaofan-luan note that I did the docs samples for C# for v2.2 - you can see the C# snippets on the Milvus website for that version (link). I'm guessing/hoping most of these can just be ported across to v2.3.

Is this something you can take care of? Of course, I'd be happy to help with anything specific (like if you need a code sample for new 2.3 functionality).

@xiaofan-luan
Copy link
Contributor Author

@xiaofan-luan note that I did the docs samples for C# for v2.2 - you can see the C# snippets on the Milvus website for that version (link). I'm guessing/hoping most of these can just be ported across to v2.3.

Is this something you can take care of? Of course, I'd be happy to help with anything specific (like if you need a code sample for new 2.3 functionality).

Yep, guessing we can migrate most of the document into 2.3
For 2.3 we changed some of the examples. We may try to migrate some of the code from old document to new document~
Probably we will need to confirm from the C# Sig all the example works.
Also we will need to support 2.4 release features, including GPU index, multi vector, sparse embedding and grouping search.
https://milvus.io/docs/release_notes.md

we can setup a meet next week to sync on the time schedule and explain the new features if necessary.

Great Work team! Please let me know if anything else we can help .Currently we are working on the new feature of 3.0.

@xiaofan-luan
Copy link
Contributor Author

BTW, we will have a unstructured meetup in Berlin later this year. @roji definitely come and meet!

@roji
Copy link
Collaborator

roji commented Mar 24, 2024

For 2.3 we changed some of the examples. We may try to migrate some of the code from old document to new document. Probably we will need to confirm from the C# Sig all the example works.

Makes sense - let me or @weianweigan know if you need help with this!

Also we will need to support 2.4 release features, including GPU index, multi vector, sparse embedding and grouping search. we can setup a meet next week to sync on the time schedule and explain the new features if necessary.

Yeah, I've gone over the release notes and I think I have a good idea of the new stuff. I'm planning to work on updating the SDK for 2.4 pretty soon (i.e. coming two weeks) - let me work on that first, and then if I have questions we can do a call, OK?

BTW, we will have a unstructured meetup in Berlin later this year. @roji definitely come and meet!

Absolutely! Tell me the dates as soon as you know them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants