Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP warning when member does not have page edit permissions #16

Open
sanderha opened this issue May 4, 2016 · 0 comments
Open

PHP warning when member does not have page edit permissions #16

sanderha opened this issue May 4, 2016 · 0 comments

Comments

@sanderha
Copy link

sanderha commented May 4, 2016

I made a member group whom I wanted to be able to view the product catalog, but not edit the products. I therefore disabled the Content permission "Edit any page".

When this permission is switched off, a PHP warning is thrown:
[Warning] Missing argument 2 for Milkyway\SS\Shop\Inventory\Extensions\ProductCatalogAdmin::Milkyway\SS\Shop\Inventory\Extensions{closure}(), called in /Applications/MAMP/htdocs/restaurant-flammen/framework/forms/gridfield/GridFieldDataColumns.php on line 143 ...

It then refers to line 26 in ProductCatalogAdmin:

'callback' => function ($record, $col, $grid) {

For this project it was okay to just enable this permission again to avoid the warning, but I thought I'd just let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant