Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoProperties : fix isClosedGop method #39

Open
valnoel opened this issue Jan 12, 2015 · 1 comment
Open

VideoProperties : fix isClosedGop method #39

valnoel opened this issue Jan 12, 2015 · 1 comment
Labels
2 - Working bug feature

Comments

@valnoel
Copy link

valnoel commented Jan 12, 2015

Need a patch in FFmpeg.
@valnoel valnoel mentioned this issue Jan 12, 2015
Merged
@cchampet cchampet removed their assignment Jan 20, 2015
@cchampet cchampet modified the milestone: 0.5.3 Feb 12, 2015
@cchampet cchampet modified the milestones: 0.5.4, 0.5.5 Mar 4, 2015
@cchampet
Copy link

cchampet commented Apr 1, 2015

Maybe not a patch...
FFmpeg's mpegvideo decoder detects the correct gop (closed or not) here:
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavcodec/mpeg12dec.c#L2386
But the information in "hidden" in a sub AVOptions-enabled children of AVCodecContext. This must be detect in avTranscoder here:
https://github.com/mikrosimage/avTranscoder/blob/develop/src/AvTranscoder/codec/ICodec.cpp#L162
But we don't get it... Maybe we need to use:
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavutil/opt.h#L685
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavutil/opt.h#L693

@cchampet cchampet modified the milestones: 0.5.5, 0.5.6 Apr 17, 2015
@cchampet cchampet mentioned this issue Apr 27, 2015
Closed
@cchampet cchampet modified the milestones: 0.5.6, 0.5.7 Apr 27, 2015
@cchampet cchampet modified the milestones: 0.5.7, 0.5.8 Jun 17, 2015
@cchampet cchampet modified the milestone: 0.5.8 Jun 17, 2015
@cchampet cchampet mentioned this issue Nov 6, 2015
Open
@valnoel valnoel removed their assignment Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - Working bug feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valnoel @cchampet