-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylance crashes when using the interactive window #6357
Comments
Thanks for the issue. Unfortunately, we cannot reproduce the problem. Can you include the That should show what's crashing in Pylance. |
I am having a similar problem. See the attached log file. I couldn't paste it here as it was too long. |
@cddesja your problem is this: 2024-09-09 09:46:57.541 [info] Error: Debug Failure. False expression: Duplicate path in cellFilePaths: untitled:/Interactive-4.interactive.py#W1sdW50aXRsZWQ%3D Looks like a bug in our interactive window handling. Same as this issue here: |
I'm able to reproduce following these steps here:
Error shows up. |
Hmm, in VS code insiders the interactive window behaves differently. It doesn't reoutput the cells from before the reload, preventing the problem from occurring. |
Might be related to the |
I think this is a bug in the vscode-languageclient-npm module. We're getting a did change event that has an impossible start index. During the onDidNotebookDocumentChange event, the start index for the NotebookCellArrayChange looks like it's including the markdown cells. It doesn't normally. This only happens when I restart. |
Nope, it was a bug in our own code. Maybe VS code started adding markdown cells to the interactive notebook recently and they weren't there before. The problem is we're not accounting for markdown cells when adding the Interactive input to the bottom of our cell list. |
Still an issue with |
I am also seeing this. I can confirm that the repro is opening/restoring a VSCode workspace with an existing ipython pane (created by running Extensions: Pylance v2024.9.1, Python v2024.14.0. Pylance logs:
|
Yes, the fix for this hasn't shipped yet. It should ship sometime this week. |
Thanks @rchiodo experiencing the same issue as the other folks. It is crashing non stop. I did put nodejs for pylance and also expanded the amount memory. Nothing seems to be working. |
Here are the logs for my case: |
@alejandro979 your issue doesn't look to be the same problem. Are you using an interactive window? If not, it's something different. I recommend opening a new issue and add a full log as described here: |
@rchiodo Yes. I'm using the interactive window. Do you still feel like I should open a new issue? Thank you |
No, it's just weird that it's not logging the same error. Maybe your trace level isn't high enough. Likely the same problem though. Our interactive window logic is just wrong. VS code must have updated to include markdown cells in the interactive window or otherwise it should have never worked. |
+1 for issue, following for fix. |
what he said ..... |
Temp. fix: Close all interactive windows and restart VSCode. Pylance works perfectly then! But there should be a setting to auto close all interactive windows while exiting VSCode. Added a feature request in VSCode (microsoft/vscode#228206)! 😊 |
I'm so annoyed and disappointed by this issue. Microsoft develops both the pylance extension and the jupyter one. Have you guys even done a test before rolling out the update? What do you mean by #6235 (comment)?
This is not a workaround but a compromise. If you can't roll out a hotfix, at least should provide the version of the extension without the bug |
This is a fix: just uninstall pylance and install the old school jedi-language-server |
There is no version of the Pylance extension without this bug. It's existed since we added interactive window support. Rolling back VS code to 1.89 might fix the issue, but then you'd also have to rollback other things as well. |
I've confirmed you can also rollback VS code to 1.89 and the problem went away for me. The Python Extension, the Pylance Extension, and the Jupyter Extension have to be rolled back to much older versions as well. |
Hi, I am reporting that I am having the same bug since yesterday.
After several crashes, I installed the 2023.10.30 version, which seems to work fine. |
This issue has been fixed in prerelease version 2024.9.100, which we've just released. You can find the changelog here: CHANGELOG.md |
i confirm i am no longer having the issue on 2024.9.100
…On Thu, Sep 12, 2024 at 6:57 PM Stella ***@***.***> wrote:
Closed #6357 <#6357>
as completed.
—
Reply to this email directly, view it on GitHub
<#6357 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFS4MIWCOT57COOUPAB3DZWITADAVCNFSM6AAAAABNYNVCCWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGI2DAMJVHA2TENI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
A temp fix from my side: |
I am still experiencing issues regarding the interactive window with 2024.9.2. |
Yes, this is expected. You have to upgrade to the 2024.9.100 version (or newer). The 100 is newer than 2 in our version scheme. |
Environment data
Code Snippet
Repro Steps
Expected behavior
Pylance should run without crashing and provide proper linting, autocompletion, and code analysis for Python files.
Actual behavior
Pylance crashes repeatedly within a few minutes of usage, and it does not restart automatically.
Logs
The text was updated successfully, but these errors were encountered: