FluentBreadcrumb and ComponentBase #287
-
Hey All, We have the FluentBreadcrumb component and its attributes do not match with the template. See below. What is the plan here? Shall the I send my PR as it is now. Once the situation above is clarified and there is a decision I'm happy to make the changes. using Microsoft.AspNetCore.Components;
namespace Microsoft.Fast.Components.FluentUI;
public partial class FluentBreadcrumb
{
/// <summary>
/// Gets or sets the content to be rendered inside the component.
/// </summary>
[Parameter]
public RenderFragment? ChildContent { get; set; }
} @namespace Microsoft.Fast.Components.FluentUI
@inherits FluentComponentBase
<fluent-breadcrumb @ref=Element
class="@Class"
style="@Style"
@attributes="AdditionalAttributes">
@ChildContent
</fluent-breadcrumb> |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
The code should definitely follow the Stange that this one slipped through. I would expect it to generate an error message along the lines of 'base classes must be the same'. Can you include the change in your test PR? Otherwise, I'll change it somewhere in the coming days. |
Beta Was this translation helpful? Give feedback.
The code should definitely follow the
.razor
file!Stange that this one slipped through. I would expect it to generate an error message along the lines of 'base classes must be the same'.
Can you include the change in your test PR? Otherwise, I'll change it somewhere in the coming days.