Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ngen uninstall workarounds #292

Open
MichaelSimons opened this issue May 28, 2019 · 2 comments
Open

Remove ngen uninstall workarounds #292

MichaelSimons opened this issue May 28, 2019 · 2 comments

Comments

@MichaelSimons
Copy link
Member

Within the SDK images there are several ngen uninstall calls to remove assemblies that have been queued to be ngen'd but fail to ngen. In order to remove the workarounds, VS will need to address their issues first.

Example:

RUN `
    # Workaround for issue with 32 bit assemblies from .NET Framework 4.8 SDK being 64 bit ngen'ed
    \Windows\Microsoft.NET\Framework64\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\SecAnnotate.exe" `
    && \Windows\Microsoft.NET\Framework64\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\WinMDExp.exe" `
    `
    && \Windows\Microsoft.NET\Framework64\v4.0.30319\ngen update `
    `
    # Workaround VS installer/ngen issues
    && \Windows\Microsoft.NET\Framework\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft Visual Studio\2019\TestAgent\Common7\IDE\VSWebLauncher.exe" `
    && \Windows\Microsoft.NET\Framework\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft Visual Studio\2019\TestAgent\Common7\IDE\CommonExtensions\Microsoft\Editor\Microsoft.VisualStudio.Diff.CommandLineSwitch.pkgdef" `
    && \Windows\Microsoft.NET\Framework\v4.0.30319\ngen uninstall "C:\Program Files (x86)\Microsoft Visual Studio\2019\TestAgent\Common7\IDE\CommonExtensions\Microsoft\Editor\Microsoft.VisualStudio.Diff.pkgdef" `
    `
    && \Windows\Microsoft.NET\Framework\v4.0.30319\ngen update
@MichaelSimons
Copy link
Member Author

@mthalman, We should take inventory of the remaining uninstalls and ensure there are active product issues to address the underlying problems.

@mthalman
Copy link
Member

mthalman commented Aug 22, 2019

The following files are uninstalled from the ngen queue to workaround issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tracking
Development

No branches or pull requests

2 participants