Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Build fails on g++ >= 13 #570

Open
MRandl opened this issue Jul 23, 2024 · 2 comments · May be fixed by #576
Open

[BUG] Build fails on g++ >= 13 #570

MRandl opened this issue Jul 23, 2024 · 2 comments · May be fixed by #576
Labels
bug Something isn't working

Comments

@MRandl
Copy link

MRandl commented Jul 23, 2024 •
edited
Loading

Expected Behavior

make should compile the application

Actual Behavior

make fails in the middle of the compilation

Example Code

Follow the Readme

Dataset Description

Not applicable

Error

cstdint import missing?

#29 2.394 /home/randl/DiskANN/include/ann_exception.h:22:65: error: 'uint32_t' has not been declared
#29 2.394    22 |                                    const std::string &fileName, uint32_t lineNum);
#29 2.394       |                                                                 ^~~~~~~~
#29 2.394 compilation terminated due to -Wfatal-errors.
#29 2.398 In file included from /home/randl/DiskANN/src/ann_exception.cpp:4:
#29 2.398 /home/randl/DiskANN/include/ann_exception.h:22:65: error: 'uint32_t' has not been declared
#29 2.398    22 |                                    const std::string &fileName, uint32_t lineNum);
#29 2.398       |

and cascading errors from there

Your Environment

Failing setup:

  • Docker container with ubuntu:latest, i.e. v24.04 noble, kernel 6.2.0-26-generic
  • DiskANN a2a0f69 (latest commit on main at the time of writing)
  • g++ 13.2.0 freshly installed from apt

Working setup:

  • replace g++ with g++-9 in CMakeLists.txt on the same container
@MRandl MRandl added the bug Something isn't working label Jul 23, 2024
@MRandl
Copy link
Author

MRandl commented Jul 23, 2024 •
edited
Loading

It is possible that a transitive dependency was removed within the cpp stdlib implementation.
Maybe related to this? https://www.reddit.com/r/Cplusplus/comments/17olfla/comment/k7zbkfz/

@MRandl
Copy link
Author

MRandl commented Jul 23, 2024 •
edited
Loading

I can try to do a quick PR by the end of the week if you'd like

@MRandl MRandl linked a pull request Aug 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix stdint import to build on g++13 MRandl/DiskANN
1 participant
@MRandl