Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Regarding warnings after update to 5.3 #1182

Open
gntpet opened this issue Aug 29, 2024 · 6 comments
Open

[Question]: Regarding warnings after update to 5.3 #1182

gntpet opened this issue Aug 29, 2024 · 6 comments
Labels
bug Something isn't working question Further information is requested

Comments

@gntpet
Copy link

gntpet commented Aug 29, 2024

Question

After upgrade AL-GO to 5.3 we do received these warnings:

The property runs-on in DeployToPROD is expected to be of type Object[]
image

Is it a code issue on your end or do we have to change something in our configs? My config looks like this:

"DeployToQA": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "QA",
    "Projects": "SRS.nl",
    "Branches": [
      "main"
    ],
    "ContinuousDeployment": true,
    "runs-on": "ubuntu-latest"
  },

Deployments works as expected

Best Regards,
Gintautas

@gntpet gntpet added the question Further information is requested label Aug 29, 2024
@gntpet gntpet changed the title [Question]: [Question]: Regarding warnings after update to 5.3 Aug 29, 2024
@gntpet
Copy link
Author

gntpet commented Sep 9, 2024

Any input on this one, @freddydk ?

@freddydk
Copy link
Contributor

freddydk commented Sep 9, 2024

Sorry, didn't see this.
You should modify your "runs-on" to

"runs-on": [ "ubuntu-latest" ]

I will add this to documentation - it doesn't clearly state that runs-on should be an array.
On github, it is clearly mentioned: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on - but you shouldn't need to read that.

@gntpet
Copy link
Author

gntpet commented Sep 9, 2024

Thanks, it did help to remove the warning.

Nevertheless, there's an slight confusion about runs-on setting. Please check the image

image

@freddydk
Copy link
Contributor

freddydk commented Sep 9, 2024

Both should be arrays as far as I know.
Maybe the first isn't checked.

@gntpet
Copy link
Author

gntpet commented Sep 9, 2024

Initially i set all of them to the type of object as per advise.
But then pipeline could not run at all and gave this error:
image

@freddydk
Copy link
Contributor

freddydk commented Sep 9, 2024

wow - strange - will have a look.

@freddydk freddydk added the bug Something isn't working label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants