Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sophisticated url normalization #21

Open
jlsuttles opened this issue Nov 4, 2013 · 9 comments
Open

Implement sophisticated url normalization #21

jlsuttles opened this issue Nov 4, 2013 · 9 comments
Assignees
Milestone

Comments

@jlsuttles
Copy link
Contributor

php-mf2 tests are comprehensive https://github.com/indieweb/php-mf2/blob/master/tests/Mf2/URLTest.php

@veganstraightedge
Copy link
Contributor

I think this should be created at a standalone gem that this gem then depends on.

@veganstraightedge
Copy link
Contributor

@aaronpk said he'd take this on and would build it as a stand alone gem.

This gem would then need to depend upon and use it.

@aaronpk
Copy link
Member

aaronpk commented May 11, 2017

Hmm this gem might already do it: https://github.com/sporkmonger/addressable Take a look at the "join" method.

@veganstraightedge
Copy link
Contributor

@veganstraightedge
Copy link
Contributor

At quick glance, seems good.

I'll leave it up to implementors to decide whether to use that or create a new gem (if addressable) ends up to be insufficient.

@jgarber623
Copy link
Member

jgarber623 commented Jul 5, 2018

I've just recently abstracted some similarly duplicative code from my own projects into the Absolutely gem which relies on Addressable under-the-hood.

I'll add some more test cases from @aaronpk's aforelinked php-mf2 test suite for completeness.

@jgarber623
Copy link
Member

…and done! Absolutely v1.1.0 adds tests from the php-mf2 URL test suite.

@jgarber623 jgarber623 modified the milestones: Post 3.0, v5.0.0 Jul 5, 2018
@jgarber623 jgarber623 self-assigned this Jul 5, 2018
@veganstraightedge
Copy link
Contributor

@jgarber623 You have the Absolutely repo tagged absolute-ur. Maybe you meant absolute-ur?

https://github.com/topics/absolute-ur

vs

https://github.com/topics/absolute-url

@jgarber623
Copy link
Member

@veganstraightedge Good catch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants