Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on local Administrator rights to trigger features and update charging thresholds #32

Open
kenimore opened this issue Aug 28, 2024 · 2 comments

Comments

@kenimore
Copy link

Currently every action (Disable Power Adapter, Charge to Full and Charge Maximum) in Battery Toolkit dropdown menu prompts for local Administrator rights.
Changing Power settings, i.e. adjusting lower and maximum limits - acts the same, triggering Administrator rights prompt.

I wonder if decoupling daemon state and configuration storage into more easily accessible user settings location (for example, ~/Library/...) will do the trick?

@mhaeuser
Copy link
Owner

This is not a technical limitation - quite the opposite, the prompts are entirely internal privilege boundaries unrelated to permissions to system resources. A location like ~/Library cannot work simply because it doesn't make sense to configure an overall system power state per user. The prompts are in place to guard against unauthorized users making changes to how the system behaves (otherwise, even the Guest user could launch the Battery Toolkit GUI and make system-wide changes). However, the current system is a bit of a crutch. I do not like the technical implementation at all and requiring a password prompt when charging to maximum or alike is probably overkill. I wanted to look into reworking this some day and will definitely consider making it less verbose. However, for making persistent changes like changing the thresholds, I think the password prompt is very well warranted.

@thomasfire
Copy link

I think this can be a configurable option. For example those folks who do not have other people in access to their mac definitely would be happy to disable the admin prompts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants