Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo API 3.4 removed link_secure #201

Open
larskn opened this issue Nov 27, 2023 · 1 comment
Open

Vimeo API 3.4 removed link_secure #201

larskn opened this issue Nov 27, 2023 · 1 comment
Assignees

Comments

@larskn
Copy link

larskn commented Nov 27, 2023

Although it is not explicitly mentioned in the changelog (https://developer.vimeo.com/api/changelog#3.4), Vimeo API 3.4 seems to have removed the link_secure field.

Whith Accept: application/vnd.vimeo.video+json;version=3.2 the field is present in the response, with Accept: application/vnd.vimeo.video+json;version=3.4 it is not.

I don't think it is a bug in the API, because it is also not listed in the current API docs (https://developer.vimeo.com/api/reference/response/video-file).

This unfortunately results in a bug with in this library since now the ***SecureLink properties are always null.

As far as I can see, the vales of link and link_secure are always the same with the 3.2 API anyway. So ***SecureLink properties maybe could just be removed. (But I am not an expert on the Vimeo API so maybe there is a difference I am not aware of.)
Since this would be a breaking change, a temporary fix could also be to deprecate the properties, return the values of the regular Links and remove the properties in the next major update.

@mfilippov
Copy link
Owner

@larskn Thanks for the info I will remove obsolete field.

@mfilippov mfilippov self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants