Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Detect duplicated images files during upload #301

Open
febo opened this issue Jul 29, 2022 · 2 comments
Open

[Feature]: Detect duplicated images files during upload #301

febo opened this issue Jul 29, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@febo
Copy link
Contributor

febo commented Jul 29, 2022

Feature

In some cases, some (several) assets might be associated with the same image file. Currently, this would lead to multiple upload (and charges) for the same file.

Ideal solution or implementation

The upload command should maintain a list of assets already uploaded and before uploading a new one, check whether is has already been uploaded or not. This can be done by comparing the hash of the image file, so even if image names are different – likely the case since they are named after the index of the asset – they won't be re-uploaded.

Alternative solutions or implementations

No response

Other context

No response

@febo febo added enhancement New feature or request good first issue Good for newcomers labels Jul 29, 2022
@0xJohnnyboy
Copy link

0xJohnnyboy commented Aug 30, 2022

Yes, especially that if using Shadow Drive, the file is accesible with its own name. But it should at least ask for confirmation that this is the expected behavior.

@AlexITC
Copy link
Contributor

AlexITC commented Mar 2, 2023

Right now, there is an imaged required for each json file, for example, having these assets won't work:

  • 0.json
  • 0.jpg
  • 1.json (linking 0.jpg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants