-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hover anchor links in HTML: https://github.com/metanorma/metanorma-og… #578
Conversation
h5:hover>a.anchor, | ||
h6:hover>a.anchor, | ||
.inline-header:hover>a.anchor{ | ||
visibility:visible; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colon after property should be followed by one space
Line should be indented 2 spaces, but was indented 0 spaces
h4:hover>a.anchor, | ||
h5:hover>a.anchor, | ||
h6:hover>a.anchor, | ||
.inline-header:hover>a.anchor{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening curly brace {
should be preceded by one space
a.header:hover{color:#a53221} | ||
a.anchor{position:absolute;z-index:1001;width:1.5ex;margin-left:-1.5ex;display:block;text-decoration:none!important;visibility:hidden;text-align:center;font-weight:400} | ||
a.anchor::before{content:"\00A7";font-size:.85em;display:block;padding-top:.1em} | ||
h1>a.anchor:hover, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
a.header{color:inherit;text-decoration:none} | ||
a.header:hover{color:#a53221} | ||
a.anchor{position:absolute;z-index:1001;width:1.5ex;margin-left:-1.5ex;display:block;text-decoration:none!important;visibility:hidden;text-align:center;font-weight:400} | ||
a.anchor::before{content:"\00A7";font-size:.85em;display:block;padding-top:.1em} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
Colon after property should be followed by one space
Declaration should be terminated by a semicolon
Opening curly brace {
should be preceded by one space
Properties should be ordered content, display, font-size, padding-top.1
should be written with a leading zero as 0.1
.85
should be written with a leading zero as 0.85
|
||
a.header{color:inherit;text-decoration:none} | ||
a.header:hover{color:#a53221} | ||
a.anchor{position:absolute;z-index:1001;width:1.5ex;margin-left:-1.5ex;display:block;text-decoration:none!important;visibility:hidden;text-align:center;font-weight:400} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! should be preceded by a space, and should not be followed by a space
!important should not be used
Avoid qualifying class selectors with an element.
Colon after property should be followed by one space
Declaration should be terminated by a semicolon
Opening curly brace {
should be preceded by one space
Properties should be ordered display, font-weight, margin-left, position, text-align, text-decoration, visibility, width, z-index
@@ -199,3 +199,24 @@ table.rouge-line-table pre { | |||
overflow-x: visible; | |||
font-size: 100%; | |||
} | |||
|
|||
a.header{color:inherit;text-decoration:none} | |||
a.header:hover{color:#a53221} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
Colon after property should be followed by one space
Color literals like #a53221
should only be used in variable declarations; they should be referred to via variable everywhere else.
Declaration should be terminated by a semicolon
Opening curly brace {
should be preceded by one space
@@ -199,3 +199,24 @@ table.rouge-line-table pre { | |||
overflow-x: visible; | |||
font-size: 100%; | |||
} | |||
|
|||
a.header{color:inherit;text-decoration:none} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
Colon after property should be followed by one space
Declaration should be terminated by a semicolon
Opening curly brace {
should be preceded by one space
expect(html).to match(%r{<h2 class="TermNum" id="paddy">1\.2\.</h2>}) | ||
html = strip_guid(File.read("test.html")) | ||
expect(html).to include(%{<div id="paddy1"><h2 class="TermNum" id="_"><a class="anchor" href="#paddy1"></a><a class="header" href="#paddy1">1\.1\.</a></h2>}) | ||
expect(html).to include(%{<div id="paddy"><h2 class="TermNum" id="_"><a class="anchor" href="#paddy"></a><a class="header" href="#paddy">1\.2\.</a></h2>}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [158/80]
expect(html).to match(%r{<h2 class="TermNum" id="paddy1">1\.1\.</h2>}) | ||
expect(html).to match(%r{<h2 class="TermNum" id="paddy">1\.2\.</h2>}) | ||
html = strip_guid(File.read("test.html")) | ||
expect(html).to include(%{<div id="paddy1"><h2 class="TermNum" id="_"><a class="anchor" href="#paddy1"></a><a class="header" href="#paddy1">1\.1\.</a></h2>}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [161/80]
|
||
a.header{color:inherit;text-decoration:none} | ||
a.header:hover{color:#a53221} | ||
a.header:visited{color:inherit;text-decoration:none} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
Colon after property should be followed by one space
Declaration should be terminated by a semicolon
Opening curly brace {
should be preceded by one space
…c/issues/659
Metanorma PR checklist