Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: different lib names and packages names #13

Open
Henry-E opened this issue Mar 13, 2024 · 0 comments
Open

Nit: different lib names and packages names #13

Henry-E opened this issue Mar 13, 2024 · 0 comments

Comments

@Henry-E
Copy link
Collaborator

Henry-E commented Mar 13, 2024

In the cargo.toml, the package name is openbook-twap and the lib name is openbook_twap.

It's not a big deal but solana-verify is very specific about using the lib name. Which makes writing scripts to deploy annoying since you have to switch between lib and package name or know which needs to be used in what scenario. If they're both the same then there's no thought required.

It's an easy change but I don't want to break anything upstream that imports openbook_twap as a lib. So would like to see it done but it's not really a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant