Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token metadata to LP tokens #175

Open
metaproph3t opened this issue Apr 26, 2024 · 3 comments
Open

Add token metadata to LP tokens #175

metaproph3t opened this issue Apr 26, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@metaproph3t
Copy link
Member

Similar to how conditional_vault has an add_metadata_to_conditional_tokens function and a corresponding script that allows us to upload metadata to conditional tokens, we should add a function / script for the AMM LP tokens.

@metaproph3t metaproph3t added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 26, 2024
@Henry-E
Copy link
Collaborator

Henry-E commented Apr 30, 2024

One thing that might cause issues when we upgrade between programs is if we reset the number of proposals back to 0 each time, then we might end up with overlapping metadata tokens.

@R-K-H
Copy link
Member

R-K-H commented Apr 30, 2024

One thing that might cause issues when we upgrade between programs is if we reset the number of proposals back to 0 each time, then we might end up with overlapping metadata tokens.

Yea I've been noodling over this given the devnet has all this kind of problem already. I'll see if I can come up with some ideas and potential solutions for this in the coming days.

@R-K-H
Copy link
Member

R-K-H commented May 7, 2024

For our UI and wallets to display sane human readable tokens, we need to be able to upload metadata for LP tokens as well as the p/f tokens.

Ideally this is modular and accepts parameters vs being hard coded and mapped in the scripts as it is right now.

The full idea from concept is:

  1. We take from DAO creation (when created) there are pass / fail images uploaded and stored in our DB (using cloudflare)
  2. We offer something similar for LP token (using cloudflare)

Then when proposal is created everything is pulling from DB, but in theory could be passed as a parameter (image url) and then it creates it accordingly.

See also: https://github.com/metaDAOproject/metadao-frontend/issues/77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

3 participants