Fix podman+selinux compatibility

[russellb]

commit c39ba23
Author: Russell Bryant [email protected]
Date: Fri Sep 27 14:05:18 2024 +0000

Fix podman+selinux compatibility

When I ran `llama stack configure` for my `docker` based stack on my
system using podman + SELinux (CentOS Stream 9), The `podman run`
command failed due to SELinux blocking access to the volume mount.

As a simple fix, disable SELinux label checking.

Signed-off-by: Russell Bryant <[email protected]>

[facebook-github-bot]

Hi @russellb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[markmc]

AFAIR, it's safe to pass ":z" to Docker or to Podman if SELinux is disabled

[markmc]

start_container.sh needs this too, perhaps with :Z for the model checkpoints dir since it would be shared between containers?

[markmc]

start_container.sh needs this too, perhaps with :Z for the model checkpoints dir since it would be shared between containers?

Also, build_container.sh - and maybe for that, since it is the llama-stack source directory, it would be better just to use --security-opt=label=disable so we're not relabelling the source dir?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[russellb]

@markmc thanks for highlighting where else this is needed! I had only changed the one spot I hit a failure in so far. I'll update this based on your feedback.

[russellb]

@markmc thanks again for the review. Can you take another look when you have a chance? Thanks!

[russellb]

start_container.sh needs this too, perhaps with :Z for the model checkpoints dir since it would be shared between containers?

Also, build_container.sh - and maybe for that, since it is the llama-stack source directory, it would be better just to use --security-opt=label=disable so we're not relabelling the source dir?

I ended up just doing this everywhere. I tried to be more clever, but when run failed because SELinux blocked access to the GPUs I gave up and took the easy route.