[hcledit/read] return error if fallback occurred #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-ph
requested review from
tcnksm,
drlau,
slewiskelly,
dtan4,
yanolab,
suzuki-shunsuke and
ryotafuwa-dev
as code owners
ryan-ph
force-pushed
the
ryan-ph/read-fallback/signal-fallback
branch
2 times, most recently
from
b45af68
to
f62f2dc
Compare
ryan-ph
force-pushed
the
ryan-ph/read-fallback/signal-fallback
branch
from
f62f2dc
to
4813513
Compare
dtan4
reviewed
Apr 24, 2024
ryan-ph
commented
Apr 24, 2024
| @@ -1,8 +1,7 @@ | |||
| name: Lint | |||
|
|
|||
| on: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
This causes the lint to run against main rather than the branch HEAD. This means the previous behavior let unlinted code make it to main, but prevents CI from passing on the next PR.
dtan4
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
title
WHY
This will clarify to users of
HCLEditor.Read()whether the values returned should be interpreted as aRawValor not. Ideally, this error should be per-key in the return map sinceHCLEditor.Read()allows you to read multiple values from the HCL config with the splat operator.