[hcledit/read] fallback to raw values if unparsable #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-ph
force-pushed
the
ryan-ph/read/default-raw-expression
branch
from
c116cb5
to
209d0da
Compare
slewiskelly
reviewed
Apr 22, 2024
ryan-ph
force-pushed
the
ryan-ph/read/default-raw-expression
branch
from
209d0da
to
54256f8
Compare
ryan-ph
commented
Apr 22, 2024
| @@ -30,3 +31,9 @@ func WithNewLine() Option { | |||
| opt.beforeNewline = true | |||
| } | |||
| } | |||
|
|
|||
| func WithReadFallbackToRawString() Option { | |||
There was a problem hiding this comment.
I generally agree with the code comment left above that we should probably split these into operation specific options, but I think that's out of scope for this PR.
dtan4
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Currently this package always passes a
nilEvalContextwhen evaluating HCL expressions. This means any value that references other attributes will fail to parse. This PR adds a fallback in this case to return the raw, un-evaluated value.WHY
There's a couple reasons why this is useful:
EvalContext.EvalContextwhen executing a read operation. When working with and writing HCL files programatically, it's useful to just get the un-evaluated value as we generally are not planning on completely evaluating and replacing interpolated values / expression references with literals.