-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jquery frontend #41
Conversation
I copied the layout from the existing files and begin to clean that stuff up so that it is easier to read and work with.
This isn't fully working yet. I still have to add the actual settings to it and make it work on the initial loading of the page. Currently you have to at least select something in the box before getting boxes for the options.
The UI loads now all necessary elements to properly send a visualize request.
Fixes the problem that the first element has 'undefinded' prepended to the string.
This new layout has all references to app_state removed in order to pull this information dynamically via REST from the backend.
for now it only uploads a single file and no information about the visualizer to use. Next step is to implement the backend for a post to visualize with a picture attached.
It is still without the visualization settings
The partial occlusion visualizer uses a different property than the others when delivering the image. This should be fixed in the backend.
…-jquery-frontend
By switching to blueprints for this as well I am able to use the factory pattern which is essential for Selenium testing.
Currently the integration tests have to run first. It's weird but the tests will hang if this is executed last. That is the reason why it has the *_a_* in it. I assume there is some collision in the fixtures that causes this behavior, probably related to app shutdown.
This is still broken in the travis file. We need to download a webdriver first.
Yes you can definitely use an image diff. That would be a really great unit test that would probably prevent a lot of bugs. I defer to your judgement on how to do front end testing. When you make a decision let me know and I'll try to help you integrate it into our CI. Maybe open a new issue if you want to discuss more =) Is this PR ready for review or are you still planning some other stuff? |
I have a half working Selenium test in there. If you don't mind having it in master (it is currently disabled) then it's good to go. We can discuss the remainder in the new ticket (#42). |
Ok cool! I'll look through as soon as possible |
This way it doesn't interfere with the unit tests and can also be triggered separately.
Sorry for the delay, leaving for Christmas Monday and tons to do as usual =) |
This PR now also includes tests for #42 and #43 in a crude manner. The integration tests just check if the website builds up and the image diff tests are inspecting one set of settings and the default settings. The integration tests are currently not part of the pipeline since I don't want to mess around with the |
It looks like the reference images are exceeding the disk quota for travis docker images. Edit: seems like this was en error on travis side not ours. |
Interesting -- is Travis still giving you problems? Do you want me to re-review now? |
Ready to review :) |
Classy stuff! I can't provide much review on the frontend files, but everything else looks good to me. Next PR: replace the old frontend with this one?? |
Sounds good, I'll add some more Selenium tests when doing the PR to make sure the frontend is properly tested. |
This Pull Request adds the frontend at
127.0.0.1:5000/v2
as a single page web app. I tried to mimic the original website as much as possible in terms of elements.fixes #24