Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for remediation on single worker node configurations #213

Open
novasbc opened this issue Jun 10, 2024 · 1 comment · May be fixed by #238
Open

Support for remediation on single worker node configurations #213

novasbc opened this issue Jun 10, 2024 · 1 comment · May be fixed by #238

Comments

@novasbc
Copy link

novasbc commented Jun 10, 2024

Existing code requires there to be at least one other peer worker node before remediation can occur, precluding SNR from remediating on a configuration with 3 control plane nodes + 1 worker node, which is a scenario we wish to support.
@novasbc
Copy link
Author

novasbc commented Jun 10, 2024

We have changes for this, preparing a PR. I noticed the requirement for additional unit tests. We had created a unit test for the configuration parameter, but not the actual functionality. We're looking into what setup we need to successfully run all the unit tests - as at present, existing unit tests fail due to what I presume are environmental differences.

@novasbc novasbc linked a pull request Oct 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable minimum worker nodecount 2024 10 02 novasbc/self-node-remediation
1 participant
@novasbc