Fix foreign key issue in migration #1107
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've noticed that if we run the migrations generated by this gem using a MySQL database we get an error that prevents the migration from being run successfully.
Specifically, when the
AddMissingUniqueIndices
migration runs, we try to remove thetag_id
index from thetaggings
table, but it fails because we have the foreign key ontags(id)
.I've encountered this problem with MySQL 5.7 (the most used nowadays), 8.0.32, and 8.0.33.
This is the error:
With this fix we remove the foreign key before the offending line, and add it again at the end, after we create the compound index.